Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Labels:
      None
    • Environment:
      HTC Sensation 2.3.3

      Description

      Seems like the layouts in high-resolution phones (like HTC Sensation) have black margins left right and botton. Investigate

        Activity

        Hide
        Eric Rosenberg added a comment -

        I don't think I will have a chance to run my test app on my high-resolution phone (HTC Rezound) for a few days, but just off the top of my head, the Support Screens element in the AndroidManifest.xml might be key here.

        The documentation is here: http://developer.android.com/guide/topics/manifest/supports-screens-element.html

        Show
        Eric Rosenberg added a comment - I don't think I will have a chance to run my test app on my high-resolution phone (HTC Rezound) for a few days, but just off the top of my head, the Support Screens element in the AndroidManifest.xml might be key here. The documentation is here: http://developer.android.com/guide/topics/manifest/supports-screens-element.html
        Hide
        Eric Rosenberg added a comment -

        After a bit of research, it looks like I was partially correct. This can be fixed with the "Supports Screens" element in the Android Manifest. As a quick note: It is the responsibility of the app that is using JMC to set these parameters in it's Manifest, not the responsibility of the Library. Additionally, since we are building against API 8, we can only explicitly support small, normal, and large screens through the Manifest. Extra large screen support (for tablets) is introduced in API 9, and I am unsure of the best way to handle this. I will continue to research how to ensure compatibility with tablets with extra large screens but in the meantime, I will submit a pull request that will at least allow compatibility with Android phones of any size.

        Show
        Eric Rosenberg added a comment - After a bit of research, it looks like I was partially correct. This can be fixed with the "Supports Screens" element in the Android Manifest. As a quick note: It is the responsibility of the app that is using JMC to set these parameters in it's Manifest, not the responsibility of the Library. Additionally, since we are building against API 8, we can only explicitly support small, normal, and large screens through the Manifest. Extra large screen support (for tablets) is introduced in API 9, and I am unsure of the best way to handle this. I will continue to research how to ensure compatibility with tablets with extra large screens but in the meantime, I will submit a pull request that will at least allow compatibility with Android phones of any size.
        Hide
        Dariusz Kordonski added a comment -

        Thanks for the fix Eric! I'll put the same lines in AndroidManifest.xml of the core library as well to serve as a template of what needs to be put into the target app's manifest.
        What's the exact issue with tablet screens? Say if an app embedding JMC Android lib is targeting API 9 and the appropriate supported screen (extra large) is declared in its manifest, wouldn't that work OOTB, since the only manifest in play, as you mentioned is the app's manifest (and not the one from the JMC lib)?

        Show
        Dariusz Kordonski added a comment - Thanks for the fix Eric! I'll put the same lines in AndroidManifest.xml of the core library as well to serve as a template of what needs to be put into the target app's manifest. What's the exact issue with tablet screens? Say if an app embedding JMC Android lib is targeting API 9 and the appropriate supported screen (extra large) is declared in its manifest, wouldn't that work OOTB, since the only manifest in play, as you mentioned is the app's manifest (and not the one from the JMC lib)?
        Hide
        Dariusz Kordonski added a comment - - edited

        Leaving this open, as we should add some docs on it probably (just document Eric's findings). Stuff that is up to application devs beyond just including the JMC project as lib project (as e.g. configuring manifest properly) must be documented better. Note: this is not to say the fix is incomplete. Eric has done all the hard work of finding out what's wrong, we just need to document it since, as said, it's not something we can just put into JMC source.

        Show
        Dariusz Kordonski added a comment - - edited Leaving this open, as we should add some docs on it probably (just document Eric's findings). Stuff that is up to application devs beyond just including the JMC project as lib project (as e.g. configuring manifest properly) must be documented better. Note: this is not to say the fix is incomplete. Eric has done all the hard work of finding out what's wrong, we just need to document it since, as said, it's not something we can just put into JMC source.
        Hide
        Eric Rosenberg added a comment -

        Good point about the tablet issue. The included sample app will probably not look great on a tablet because the API we use doesn't support the extra-large screen element, but when developers use JMC in their own app, there should be nothing stopping them from declaring whatever screen sizes they need.

        Show
        Eric Rosenberg added a comment - Good point about the tablet issue. The included sample app will probably not look great on a tablet because the API we use doesn't support the extra-large screen element, but when developers use JMC in their own app, there should be nothing stopping them from declaring whatever screen sizes they need.
        Hide
        Robert Massaioli added a comment -

        Dariusz Kordonski After lightly reading this is the only step remaining to document what you need to add to your Android manifest?

        Show
        Robert Massaioli added a comment - Dariusz Kordonski After lightly reading this is the only step remaining to document what you need to add to your Android manifest?

          People

          • Assignee:
            Dariusz Kordonski
            Reporter:
            Dariusz Kordonski
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated: